fix Issue 23343 - ImportC: functions declared with asm label to set s…

[WalterBright]

…ymbol name gets extra underscore prepended

Rebooted due to @ibuclaw 's suggestion in #14485

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23343	normal	ImportC: functions declared with asm label to set symbol name gets extra underscore prepended

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14486"

[ibuclaw]

Don't we have a string concatenation helper that avoids GC calls?

[WalterBright]

I don't think it's necessary here.

[ibuclaw]

@WalterBright I'll let you decide which method you prefer. I have no problem with adding special handling in the codegen pass - though the other PR needs to expose any new enum constants to C++ in order to be usable.

This method is not without its own side effects either - suddenly pragma(mangle, "*foo") has a special meaning - though gdc has always had this behaviour since pragma mangle was introduced.

[WalterBright]

I figure if gcc users can abide by the '*' prefix, then we have an excuse in doing the same thing.

[WalterBright]

This scheme isn't going to work. Too many places where the identifier is used.

[ibuclaw]

This scheme isn't going to work. Too many places where the identifier is used.

That's a sign that you should have it all in reusable function.

[RazvanN7]

This scheme isn't going to work. Too many places where the identifier is used.

Does this mean #14485 is going to be preferred over this?