Fix 23386 - Segfault on enum member UDA inside template #14522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumMember.syntaxCopycallsUserAttributeDeclaration.syntaxCopywhich will copy theAttribDeclaration.declarray, including the originalEnumMember, resulting in endless recursion.Parameter.syntaxCopydoesn't have this problem because the parser doesn't add theParameterto the uda'sdecllist, and before #11527 neither did the parser add anEnumMemberto the uda'sdecl. This PR restores the old behavior since it seems to be unrelated to the fix, though it's still not ideal thatsyntaxCopydoesn't protect against cycles in the AST.Targeting master assuming stable is still closed (@ibuclaw)