Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 23386 - Segfault on enum member UDA inside template #14522

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Oct 4, 2022

EnumMember.syntaxCopy calls UserAttributeDeclaration.syntaxCopy which will copy the AttribDeclaration.decl array, including the original EnumMember, resulting in endless recursion.

Parameter.syntaxCopy doesn't have this problem because the parser doesn't add the Parameter to the uda's decl list, and before #11527 neither did the parser add an EnumMember to the uda's decl. This PR restores the old behavior since it seems to be unrelated to the fix, though it's still not ideal that syntaxCopy doesn't protect against cycles in the AST.

Targeting master assuming stable is still closed (@ibuclaw)

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23386 regression Segfault on enum member UDA inside template

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14522"

@RazvanN7 RazvanN7 merged commit 9ceae92 into dlang:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants