Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot slice xmm rvalue #14580

Merged
merged 1 commit into from
Oct 22, 2022
Merged

cannot slice xmm rvalue #14580

merged 1 commit into from
Oct 22, 2022

Conversation

WalterBright
Copy link
Member

Attempting to slice a vector register rvalue results in bad code generation.

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 20, 2022

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
19788 normal compiler crash on slicing a enum typed as vector

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14580"

@WalterBright
Copy link
Member Author

Fixing incorrect solution #12043

@WalterBright WalterBright force-pushed the XMMreturn branch 4 times, most recently from b63bda0 to f8dbde0 Compare October 21, 2022 08:07
@ljmf00
Copy link
Member

ljmf00 commented Oct 21, 2022

Fixing incorrect solution #12043

Reference the issue in the commit, so the bot can cross reference it with the issue tracker.

@WalterBright
Copy link
Member Author

@ljmf00 ok

@WalterBright WalterBright merged commit 5319fd8 into dlang:master Oct 22, 2022
@WalterBright WalterBright deleted the XMMreturn branch October 22, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants