Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23456 - OpenBSD: Add waitid support #14612

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

ibara
Copy link
Contributor

@ibara ibara commented Nov 3, 2022

As stated, we support waitid(2) now.
https://marc.info/?l=openbsd-cvs&m=166671373628366&w=2

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ibara! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23456 enhancement OpenBSD: Add waitid support

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14612"

@ibuclaw
Copy link
Member

ibuclaw commented Nov 3, 2022

It is might be nice if we could gate this by version, but not necessary.

@dkorpel
Copy link
Contributor

dkorpel commented Nov 3, 2022

What does you mean with "gate this by version"?

@ibara
Copy link
Contributor Author

ibara commented Nov 3, 2022

At least for the OpenBSD packages, there will never be a case where someone installs a package of DRuntime with waitid support but not have an OpenBSD system that does not have waitid support. If the user doesn't use the package, they are on their own, and should know better.

@RazvanN7 RazvanN7 merged commit 0c86272 into dlang:stable Nov 4, 2022
@ibara ibara deleted the openbsd-waitid branch November 4, 2022 11:18
@ibuclaw ibuclaw mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants