Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23463 - Don't count skipped function overloads when limiting overloads shown #14620

Merged
merged 4 commits into from
Nov 5, 2022

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Nov 5, 2022

This also fixes spurious all candidates marked deprecated/@disable in verbose mode.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23463 trivial Don't count skipped function overloads when limiting overloads shown

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14620"

@@ -62,3 +62,6 @@ void main()
t_1();
t_2();
}

// ignored
deprecated void f_2(char);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this pull, after the f_2 candidates are printed this line triggers:

... (2 more, -v to show) ...

Instead of the existing 1 more.

@ntrel ntrel marked this pull request as ready for review November 5, 2022 18:57
@thewilsonator thewilsonator merged commit 130433a into dlang:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants