Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 19623 - HERE string identifier cannot start with Unicode letter #14625

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Nov 6, 2022

p-- assumes the last decoded char was a single code unit, so in case of a Unicode letter, the identifier is scanned starting in the middle of a code point.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19623 trivial HERE string identifier cannot start with Unicode letter

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14625"

@ibuclaw
Copy link
Member

ibuclaw commented Nov 6, 2022

A good example of a fix for stable.

  1. Is localised
  2. Fixes a bug report.

@dkorpel dkorpel marked this pull request as ready for review November 6, 2022 19:58
@dkorpel
Copy link
Contributor Author

dkorpel commented Nov 6, 2022

On the other hand, it's old and obscure, so there's no pressure to put it in a release quickly.

@dlang-bot dlang-bot merged commit a7f8c84 into dlang:master Nov 7, 2022
@dkorpel dkorpel deleted the heredoc-unicode branch November 7, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants