Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23516 - Anonymous enum without base type causes segfault inferring member value #14658

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Nov 28, 2022

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 28, 2022

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23516 critical Anonymous enum without base type causes segfault inferring member value

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14658"

@ntrel
Copy link
Contributor Author

ntrel commented Nov 29, 2022

ae test strikes again:

Running ae-test-library
std.socket.SocketOSException@std/socket.d(2841): Unable to bind socket: Cannot assign requested address

Edit: filed https://issues.dlang.org/show_bug.cgi?id=23518

@ntrel ntrel marked this pull request as ready for review November 29, 2022 17:46
@RazvanN7
Copy link
Contributor

RazvanN7 commented Dec 1, 2022

Could you please rebase? It might fix it. Also, I have updated the severity of the issue. ICEs are always critical bugs.

@RazvanN7
Copy link
Contributor

RazvanN7 commented Dec 1, 2022

Also, please target stable when you rebase.

@ntrel ntrel changed the base branch from master to stable December 3, 2022 11:28
…ferring member value

Use base type if available
@ntrel
Copy link
Contributor Author

ntrel commented Dec 3, 2022

Rebased to stable.

Hmm, now DAutoTest is failing:

git clone -b v2.101.0 --depth=1 https://github.com/dlang/druntime .generated/druntime-2.101.0
Cloning into '.generated/druntime-2.101.0'...
warning: Could not find remote branch v2.101.0 to clone.
fatal: Remote branch v2.101.0 not found in upstream origin
posix.mak:580: recipe for target '.generated/druntime-2.101.0' failed

@CyberShadow it seems to be using github.com/dlang/druntime instead of dmd/druntime.

@RazvanN7 RazvanN7 merged commit e419af2 into dlang:stable Dec 5, 2022
ntrel added a commit to ntrel/dmd that referenced this pull request Dec 7, 2022
@ibuclaw ibuclaw mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants