Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23539 - [REG master] Scope C++ definition out of sync with D #14673

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Dec 4, 2022

And synchronize headers with the D sources. Flip over the enums to enum class and remove long gone members.

GDC only requires Scope for ->_module, ->flags, and SCOPE::ctfe.
LDC only requires Scope for ->func, ->_module, and ->search(...).

@ibuclaw ibuclaw added Severity:Regression PRs that fix regressions Compiler:GDC Gnu D Compiler Compiler:LDC LLVM based D Compiler Feature:extern (C/C++/Obj-C) interfacing to C, C++, Objective-C code labels Dec 4, 2022
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 4, 2022

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
23539 regression [REG master] Scope C++ definition out of sync with D

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14673"

@dlang-bot dlang-bot merged commit de82301 into dlang:master Dec 4, 2022
@ibuclaw ibuclaw deleted the reg23539 branch December 4, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler:GDC Gnu D Compiler Compiler:LDC LLVM based D Compiler Feature:extern (C/C++/Obj-C) interfacing to C, C++, Objective-C code Merge:auto-merge Severity:Bug Fix Severity:Regression PRs that fix regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants