Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use VERSION file to generate version string #1469

Merged
merged 1 commit into from Jan 13, 2013

Conversation

Projects
None yet
5 participants
Member

9rnsr commented Jan 12, 2013

No description provided.

@9rnsr 9rnsr referenced this pull request Jan 12, 2013

Merged

Add VERSION file #1429

Owner

andralex commented Jan 12, 2013

This is way complicated. Isn't it much simpler to use on both Unix and Windows:

echo '"' >version.h
${CAT} VERSION >>version.h
echo '"' >>version.h

Owner

andralex commented Jan 12, 2013

Hm that doesn't work because of the extra newlines and echo -n may not exist on Windows.

Owner

braddr commented Jan 12, 2013

forgot win64.mak

Does this work in walter's make? echo "#define VERSION_STRING "cat VERSION"" > version.h

Member

9rnsr commented Jan 13, 2013

In Windows platform, built-in shell (cmd.exe) based text processing is much limited. To make things portable, vergen.c is necessary IMO.

forgot win64.mak

dmd doesn't have it, whereas druntime and Phobos have.

@WalterBright WalterBright added a commit that referenced this pull request Jan 13, 2013

@WalterBright WalterBright Merge pull request #1469 from 9rnsr/vergen
Use VERSION file to generate version string
73649ea

@WalterBright WalterBright merged commit 73649ea into dlang:master Jan 13, 2013

1 check passed

default Pass: 10
Details

I think version should be taken from git describe, I created an issue so it doesn't get lost, if I have some time I'll try to implement it myself: http://d.puremagic.com/issues/show_bug.cgi?id=9316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment