Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix Issue 23548 - [REG 2.098] C sources files have precedent over D modules in imports" #14692

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

WalterBright
Copy link
Member

Reverts #14687

Reverted until consensus can be reached on what the behavior should be.

ping @ibuclaw @Geod24 @thewilsonator

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23548 regression [REG 2.098] C sources files have precedent over D modules in imports

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14692"

@adamdruppe
Copy link
Contributor

ImportC should never have hijacked D syntax in the first place. We ought to define something separate.

@Geod24
Copy link
Member

Geod24 commented Dec 12, 2022

@WalterBright : Release is not happening tomorrow, so can we have the conversation here about what the behavior should be?

I think things I've been pulled a bit fast, so we can either pull this fast as well (which is just adding to the confusion), or have a conversation, with the shared understanding that no release is going to happen without:
a) A solution that we agree on, OR;
b) This PR being pulled in the absence of a solution;

If you disagree with that approach, we can just pull this as-is.

@WalterBright
Copy link
Member Author

@Geod24 thanks for the sensible approach. I'm ok with (a).

@WalterBright
Copy link
Member Author

@adamdruppe the idea is so the user can change the language of the imported code without breaking the importer code.

@WalterBright
Copy link
Member Author

Or more precisely, it shouldn't matter to the importer how the importee is implemented.

@ibuclaw
Copy link
Member

ibuclaw commented Dec 15, 2022

Merging, because let's keep current broken behaviour in point release for now -> fix in next major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants