Fix Issue 23549, 22587 - Lower certain noreturn expressions to a comm…

[maxhaton]

…a expression rather than a cast.

This avoids a backend segfault.

GDC already does this lowering so it may have to be made optional via a frontend parameter.

[dlang-bot]

Thanks for your pull request, @maxhaton!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	22587	normal	ternary with function call and assert(0) leads to cod1 assertion
✓	23549	regression	assert(0) as default parameter causes segfault

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14698"

[ibuclaw]

…a expression rather than a cast.

This avoids a backend segfault.

GDC already does this lowering so it may have to be made optional via a frontend parameter.

Yeah, I think that's right, shouldn't matter whoever lowers it. Did you confirm via godbolt?

[ibuclaw]

GDC rox. https://d.godbolt.org/z/rhT65MzGq