Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23548 - [REG 2.098] C sources files have precedent over D modules in imports #14700

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Dec 15, 2022

Restores import behaviour to pre-2.098. ImportC is not part of the language, it's an add-on, and shouldn't hijack the importing of D modules.

Other choices include:

  • Do the same as we have for import("foo.c"), and have a specific list of include paths only searched for .c, .h, and .i files.
  • Change syntax to import(C) foo; so there can be no ambiguity in the language.
  • Likewise, but use import "foo.h".
  • MixinC: http://dpldocs.info/experimental-docs/mixinc.html

@ibuclaw ibuclaw added the Severity:Regression PRs that fix regressions label Dec 15, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
23548 regression [REG 2.098] C sources files have precedent over D modules in imports

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14700"

@RazvanN7 RazvanN7 merged commit b0cf6b7 into dlang:master Dec 15, 2022
@ibuclaw
Copy link
Member Author

ibuclaw commented Dec 15, 2022

oh no not again #14692 #14687

@ibuclaw ibuclaw deleted the issue23548 branch December 30, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants