Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 23566 - ImportC: __PRETTY_FUNCTION__ is not defined #14712

Merged
merged 1 commit into from
Dec 19, 2022
Merged

fix Issue 23566 - ImportC: __PRETTY_FUNCTION__ is not defined #14712

merged 1 commit into from
Dec 19, 2022

Conversation

WalterBright
Copy link
Member

No description provided.

@WalterBright WalterBright added Review:Easy Review Feature:ImportC Pertaining to ImportC support labels Dec 18, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23566 enhancement ImportC: __PRETTY_FUNCTION__ is not defined

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14712"

@WalterBright WalterBright force-pushed the fix23566 branch 4 times, most recently from bf4be11 to 40d4ab8 Compare December 18, 2022 08:27
@WalterBright
Copy link
Member Author

The Azure failure is:

>>> TARGET FAILED: runnable\test23566.c
FAILED targets:
- runnable\test23566.c
##[error]Cmd.exe exited with code '1'.

No other information given.

@WalterBright
Copy link
Member Author 

src\importc.h(82) : Preprocessor error: macro '__PRETTY_FUNCTION__' can't be #undef'd or #define'd

Sigh. Microsoft's preprocessor defeats the purpose of a preprocessor.

@WalterBright WalterBright force-pushed the fix23566 branch 6 times, most recently from b1bd1a1 to b3a8430 Compare December 19, 2022 04:50
@WalterBright
Copy link
Member Author

Found an easier way.

@RazvanN7 RazvanN7 merged commit 5f2761d into dlang:master Dec 19, 2022
@WalterBright WalterBright deleted the fix23566 branch December 19, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljmf00 ljmf00 ljmf00 left review comments

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
Feature:ImportC Pertaining to ImportC support Review:Easy Review Severity:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WalterBright @dlang-bot @ljmf00 @thewilsonator @RazvanN7