Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 23499 - inliner crashes/asserts when building for 32-bit #14721

Closed
wants to merge 0 commits into from
Closed

fix Issue 23499 - inliner crashes/asserts when building for 32-bit #14721

wants to merge 0 commits into from

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 20, 2022 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14721"

thewilsonator
thewilsonator approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICE to stable

@WalterBright WalterBright force-pushed the fix23499 branch 2 times, most recently from bc4e074 to 235bd1c Compare December 20, 2022 07:34
@RazvanN7 RazvanN7 requested a review from ibuclaw as a code owner December 21, 2022 12:02
@RazvanN7 RazvanN7 changed the base branch from master to stable December 21, 2022 12:02
@RazvanN7
Copy link
Contributor

I rebased it on stable.

@RazvanN7
Copy link
Contributor

Ah darn. @WalterBright when rebasing I somehow managed to delete the changes of this PR. Do you still have the changes on your local branch?

@RazvanN7 RazvanN7 closed this Dec 21, 2022
@RazvanN7
Copy link
Contributor

I have rebooted this: #14730

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@ibuclaw ibuclaw Awaiting requested review from ibuclaw

Assignees
No one assigned
Labels
Review:Easy Review Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WalterBright @dlang-bot @RazvanN7 @thewilsonator