Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23307 - [REG][CODEGEN][SIMD] wrong codegen with inlined loc… #14733

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

WalterBright
Copy link
Member

…al functions + SIMD

It's working for me, so just adding the test case.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23307 regression [REG][CODEGEN][SIMD] wrong codegen with inlined local functions + SIMD

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14733"

compiler/test/runnable/test23307.d Outdated Show resolved Hide resolved
@RazvanN7 RazvanN7 merged commit 2655129 into dlang:master Dec 22, 2022
@ibuclaw
Copy link
Member

ibuclaw commented Dec 22, 2022

@RazvanN7 why?

@RazvanN7
Copy link
Contributor

You haven't requested changes and @WalterBright addressed your comment.

RazvanN7 added a commit to RazvanN7/dmd that referenced this pull request Dec 22, 2022
@ibuclaw
Copy link
Member

ibuclaw commented Dec 22, 2022

You haven't requested changes and @WalterBright addressed your comment.

No he didn't.

@WalterBright WalterBright deleted the fix23307 branch December 22, 2022 20:31
RazvanN7 added a commit to RazvanN7/dmd that referenced this pull request Dec 23, 2022
dlang-bot pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants