fix Issue 23589 - [REG2.095] Purity check special case gives circular reference error #14750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#14750" |
thewilsonator
approved these changes
Dec 28, 2022
|
I think it's best if you can add these references in the comments below https://issues.dlang.org/show_bug.cgi?id=18694 |
JohanEngelen
approved these changes
Dec 28, 2022
|
I'll let @kinke analyze this ex post facto. |
JohanEngelen
added a commit
to weka/ldc
that referenced
this pull request
Dec 30, 2022
…iling agent code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like this is another case of running semantic-related things in the wrong place - or not having a clear separation between resolving types/sizes, and doing validation checks.
This looks wrong, but it keeps both the introducing, and regression tests happy. @kinke ?