core.thread.osthread: Don't subtract suspend counter if thread has detached itself #14763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14763" |
schveiguy
approved these changes
Dec 30, 2022
|
If this works, it would be good to have a bug report so it goes in the changelog. I can put one in if you want. |
Go for it! |
ibuclaw
changed the title
ibuclaw
force-pushed
the
fix-freebsd2
branch
2 times, most recently
from
5a1648d to
42e4d4d
Compare
…rent thread has detached itself. Don't subtract suspend counter if thread has detached itself.
|
I'll run the testsuite one more time before hitting auto-merge. |
ibuclaw
force-pushed
the
fix-freebsd2
branch
from
42e4d4d to
096b48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FreeBSD failing test suite in master 2 (Electric Boogaloo)
More debugging done in #14754.