Fix Issue 23261 - druntime core.std.attribute.Tagged1_2 constructor i…

[RazvanN7]

…s unsafe

[dlang-bot]

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23261	normal	druntime core.std.attribute.Tagged1_2 constructor is unsafe

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14771"

[PetarKirov]

Suggested change

	this(string[] tags...) @safe
	this(string[] tags...) @safe pure nothrow

[RazvanN7]

@PetarKirov done.

[Geod24]

As mentioned in the issue, this code is only intended to be used as an UDA, so this issue doesn't make sense IMO.

[PetarKirov]

@Geod24 it's true that whether a problem exists at runtime or only theoretically at compile-time drastically changes the stakes. That said, I see no reason to keep an obviously unsafe code (even if the unsafety is theoretical) given how easy the fix is.