Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.sys.posix.sys.stat: Fix duplicate definition of __mode_t on Musl #14793

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

CyberShadow
Copy link
Member

The definition was conflicting with the other definitions within the same file.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @CyberShadow!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14793"

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to inverse the version condition.

@CyberShadow
Copy link
Member Author

I think ideally we want to decide if this is a definition tied to the platform or libc, not this odd mix of both. So, I could remove the definitions from the platform blocks and add one to all the libc blocks, or the other way around.

@ibuclaw
Copy link
Member

ibuclaw commented Jan 8, 2023

I think ideally we want to decide if this is a definition tied to the platform or libc, not this odd mix of both. So, I could remove the definitions from the platform blocks and add one to all the libc blocks, or the other way around.

I've already done a lot of this (dlang/druntime#3710) - so feel free to continue running with the baton if there's any more places didn't get in the first wave.

@CyberShadow
Copy link
Member Author

OK, is this better?

The definition was conflicting with the other definitions within the
same file.
@ibuclaw ibuclaw merged commit 18998ac into dlang:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants