fix Issue 23614 - ImportC: __int128 not supported #14805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Review:Blocking Other Work
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#14805" |
| @@ -96,3 +96,7 @@ | |||
| #if linux // Microsoft won't allow the following macro | |||
| #define __PRETTY_FUNCTION__ __func__ | |||
| #endif | |||
|
|
|||
| #if __APPLE__ | |||
There was a problem hiding this comment.
I assume DMD doesn't support 128 bit integers on any platforms?
There was a problem hiding this comment.
Then why are undefing it just for Apple?
There was a problem hiding this comment.
Because that's the only platform that complains about it.
Note that the Standard .h files are quite different on each platform.
|
This should target stable. @WalterBright please check the bot message, it guides you when and how to retarget stable. |
dkorpel
approved these changes
Jan 13, 2023
WalterBright
force-pushed
the
fix23614
branch
from
2e02e18
to
0b3d670
Compare
dkorpel
pushed a commit
to WalterBright/dmd
that referenced
this pull request
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix using Jacob Carlborg's suggestion.
This blocks compiling the BearSSL package.