fix Issue 23618 - Right Shift equals expressions on unsigned shorts s…

[WalterBright]

…hould be unsigned right shift

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23618	blocker	Right Shift equals expressions on unsigned shorts should be unsigned right shift

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14814"

[ibuclaw]

Don't merge this on master, this is affecting industry.

[WalterBright]

@ibuclaw ???

[WalterBright]

I don't understand what change you are requesting. This is listed as a blocker bug. The fix is isolated to dmd. You said that gdc and ldc don't have this issue.

[dkorpel]

The requested change is to target stable

[WalterBright]

1. this problem has been there for many years, with apparently nobody reporting it. I don't see a rush to put it into stable
2. it carries a small risk of someone relying on the old behavior. That should disqualify it from stable.

[WalterBright]

But you can put it in stable if you prefer. I just want it fixed.

Not targeting master anymore

[ibuclaw]

But you can put it in stable if you prefer. I just want it fixed.

Putting things in master won't fix the problem, you're just delaying the fix being released until 3 months down the line. In the meantime companies are complaining and want it released now.

[WalterBright]

Thanks all for taking care of this.

[CyberShadow]

"Companies want [breaking change] right now" is perhaps not a good scalable approach in general.

Not that there isn't the problem that different users of D will want different proportions of stability vs. hotfixes (which suit them in that moment). I know Digger isn't amazing right now but I think having tooling which allows building site-specific variants of D is the best general solution to these problems.

[ibuclaw]

"Companies want [breaking change] right now" is perhaps not a good scalable approach in general.

Both GDC and LDC produce the correct code, as well as any C/C++ compiler (apart from DMC it seems, if I understand the version(MARS) condition right). DMD is just plain wrong here.