Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable #14815

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Merge stable #14815

merged 3 commits into from
Jan 14, 2023

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 14, 2023

This might unblock dlang/phobos#8663

@dkorpel dkorpel requested a review from ibuclaw as a code owner January 14, 2023 12:20
@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 14, 2023

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20520 regression Runtime segfault when taking typeid of a class instanciated within an enum
23614 blocker ImportC: __int128 not supported
23618 blocker Right Shift equals expressions on unsigned shorts should be unsigned right shift

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14815"

@dkorpel dkorpel added the Review:Blocking Other Work review and pulling should be a priority label Jan 14, 2023
@deavmi
Copy link

deavmi commented Sep 30, 2023

Is this in a recent D release?

@deavmi
Copy link

deavmi commented Sep 30, 2023

Is this in a recent D release?

Asking because of the _int128 support...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants