Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 23625 - Function ZeroMemory missing in windows headers #14816

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

KytoDragon
Copy link
Contributor

Add missing functions ZeroMemory, FillMemory, CopyMemory and MoveMemory in the windows headers, forwarding to memset, memcpy and memmove.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 14, 2023

Thanks for your pull request and interest in making D better, @KytoDragon! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23625 normal Function ZeroMemory missing in windows headers

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14816"

@dkorpel
Copy link
Contributor

dkorpel commented Jan 14, 2023

I removed a trailing white space that made the pre-commit check fail. I also added "Fix 23625" to the commit message so the bot links the issue.

@dlang-bot dlang-bot merged commit 7eb96c8 into dlang:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants