fix Issue 21492 - betterC: TypeInfo is generated for code guarded by … #14830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14830" |
|
This is failing to compile d_test_run.d with an assert failure: It would be better if the test runner is compiled with the bootstrap compiler, so the compiler tests can be run. |
WalterBright
force-pushed
the
fix21492
branch
2 times, most recently
from
84977e7
to
4d7a984
Compare
WalterBright
force-pushed
the
fix21492
branch
from
4d7a984
to
f90b298
Compare
ljmf00
reviewed
Jan 17, 2023
| case 1: | ||
| if (__ctfe) | ||
| { | ||
| { int[] foo = [1]; } |
|
The Cybershadow failure appears to be a heisenbug. This PR is ready to go. |
dkorpel
approved these changes
Jan 17, 2023
RazvanN7
approved these changes
Jan 17, 2023
|
Do we really need more special cases? |
|
This PR caused a regression https://issues.dlang.org/show_bug.cgi?id=23710 |
|
Regression fix #14916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…if(__ctfe)
Code protected by
if (__ctfe)need not have any code generated for it, as illustrated by the bug report. Generating code for it anyway will trigger an error that certain things are not allowed in -betterC code, but are allowed in ctfe code.Normally, the backend will do just fine eliminating such dead code. But the error detection occurs before the backend. To do it thoroughly in the front end requires data flow analysis. But that's awful expensive for just this problem. So this PR implements a rather primitive method which will handle the usual cases. The cases it doesn't handle (and such can be easily contrived) will still trigger the error. But such are easily rewritten into the form that is accepted, so nothing is worse off.
More cases can be worked in if the future if it becomes necessary.