Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 23688 - FTBFS: error: cannot convert 'Expression' to 'Expression*' #14872

Merged
merged 1 commit into from
Feb 12, 2023
Merged

fix Issue 23688 - FTBFS: error: cannot convert 'Expression' to 'Expression*' #14872

merged 1 commit into from
Feb 12, 2023

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Feb 12, 2023

This wasn't checked during review in #14837.

@ibuclaw ibuclaw added Severity:Regression PRs that fix regressions Compiler:GDC Gnu D Compiler Compiler:LDC LLVM based D Compiler Review:Blocking Other Work review and pulling should be a priority Feature:extern (C/C++/Obj-C) interfacing to C, C++, Objective-C code labels Feb 12, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23688 regression FTBFS: error: cannot convert 'Expression' to 'Expression*'

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14872"

@maxhaton
Copy link
Member

Stable?

@thewilsonator
Copy link
Contributor

#14837 was a recent merge into master. This is not in stable.

@maxhaton
Copy link
Member

Ok

@dlang-bot dlang-bot merged commit 4b1b76d into dlang:master Feb 12, 2023
@ibuclaw ibuclaw deleted the issue23688 branch February 12, 2023 16:08
@teodutu teodutu mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
Compiler:GDC Gnu D Compiler Compiler:LDC LLVM based D Compiler Feature:extern (C/C++/Obj-C) interfacing to C, C++, Objective-C code Merge:auto-merge Review:Blocking Other Work review and pulling should be a priority Severity:Bug Fix Severity:Regression PRs that fix regressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibuclaw @dlang-bot @maxhaton @thewilsonator