Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inferred pure @nogc notrhow errors #14911

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Feb 24, 2023

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14911"

@schveiguy
Copy link
Member

Awesome! Is nothrow hard to do at the same time?

@dkorpel
Copy link
Contributor Author

dkorpel commented Mar 3, 2023

Awesome! Is nothrow hard to do at the same time?

It's a bit harder because it's not checked directly in expression semantic like the others, considering it needs to account for catch blocks, but it should be doable with a little refactoring.

@dkorpel dkorpel force-pushed the attr-inference-diag branch 3 times, most recently from 4ddcdf1 to c2293f3 Compare March 10, 2023 21:20
@dkorpel dkorpel marked this pull request as ready for review March 10, 2023 21:37
@dkorpel dkorpel requested a review from ibuclaw as a code owner March 10, 2023 21:37
@dkorpel dkorpel changed the title Improve inferred pure @nogc errors Improve inferred pure @nogc notrhow errors Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants