Fix Issue 22760 - Segmentation fault in CppMangleVisitor.template_arg #15099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For aggregate declarations at the template level the parent is not the template instance but the aggregate. For example:
For a given instantiation, say
T!int, the parent of S is notT!intbutT!int.T. That is because the compiler rewrites the struct to an eponymous template. That is why, in this PR, I am checking the parent of parent for writing the cpp mangled name. I am keeping the old case because there are situations such as:In this case, the parent of
ais going to beT!whatever, notT!whatever.T.@Geod24 can you please take a look at this, since you are the original author? I don't particularly like this fix, it looks like a special case handling, however, I have no idea if a better fix is possible.