-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove function prototypes from backend pt1 #15111
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15111" |
0a08f5e
to
e18e823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
compiler/src/dmd/backend/aarray.d
Outdated
| @@ -22,7 +22,7 @@ alias hash_t = size_t; | |||
| version (MARS) | |||
| { | |||
| import dmd.root.hash; | |||
| import dmd.backend.global : err_nomem; | |||
| import dmd.backend.ph2 : err_nomem; | |||
| } | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps err_nomem should be moved to dmd.backend.global? It feels like a more central utility function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now importing them through dmd.backend.global again using the public import
e18e823
to
8d37a74
Compare
8d37a74
to
2a6e62f
Compare
Remove function prototypes and resolve the resulting errors:
privatefunctionspublicxmmloadandxmmstore@nogcin ph2