Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function prototypes from backend pt1 #15111

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Apr 17, 2023

Remove function prototypes and resolve the resulting errors:

  • turning some private functions public
  • missing default parameter in xmmload and xmmstore
  • missing @nogc in ph2

@dkorpel dkorpel added Severity:Refactoring No semantic changes to code Compiler:Backend glue code, optimizer, code generation labels Apr 17, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15111"

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -22,7 +22,7 @@ alias hash_t = size_t;
version (MARS)
{
import dmd.root.hash;
import dmd.backend.global : err_nomem;
import dmd.backend.ph2 : err_nomem;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps err_nomem should be moved to dmd.backend.global? It feels like a more central utility function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now importing them through dmd.backend.global again using the public import

@dkorpel dkorpel marked this pull request as ready for review April 18, 2023 08:58
@RazvanN7 RazvanN7 merged commit fd9b5e8 into dlang:master Apr 24, 2023
@dkorpel dkorpel deleted the backend-prototypes-1 branch April 24, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler:Backend glue code, optimizer, code generation Severity:Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants