-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert deprecation of body #15379
revert deprecation of body #15379
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15379" |
|
It hurts the planned ability to free the body keyword for use as a name. It also hurts trust in the language. It's been two years since the first release with the deprecation. People (myself included) have already made all the necessary changes. What else will be undone? Can we trust any of the other DIPs to remain implemented? I do not like this uncertainty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as noted the whole point of removing body as a keyword is so that is can be used as a variable name, deprecation is the first step towards that and we shouldn't be undoing that.
|
Using
We don't want to break those, either. The whole point of this initiative is to stop breaking peoples' existing code. |
I see this was already mentioned.
When did that happen? I only recall the many posts where users say they couldn't use body. |
I don't know, but the proof is here: https://github.com/dlang/dmd/pull/15379/files#diff-197670928b0e5ec0254c1edd8b3588469b86ac670c013a2d0d42426a6d36b47eR719 |
body can already be used as a variable name
|
Yes, this is how it should have been done in the first place. |
The code comment says it all:
"
bodywas quite widely used"And it doesn't actually hurt anything to leave it in.