doc.d: use errorSink #15471
Merged
doc.d: use errorSink #15471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Review:Easy Review
Severity:Refactoring
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15471" |
thewilsonator
approved these changes
Jul 29, 2023
| @@ -5180,10 +5181,10 @@ private void highlightCode3(Scope* sc, ref OutBuffer buf, const(char)* p, const( | |||
| */ | |||
| private void highlightCode2(Scope* sc, Dsymbols* a, ref OutBuffer buf, size_t offset) | |||
| { | |||
| uint errorsave = global.startGagging(); | |||
There was a problem hiding this comment.
Yeah, gagging is an ugly kludge. ErrorSink is a solid solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make dmd an LSP, messages to stderr will have to be abstracted away. This does it for doc.d.
This required adding
warningSupplemental.