Fix issue 24340 - Invalid export directives generated

[rikkimax]

Found this one out when testing Rainer's shared library support.

Doesn't look like the other object file formats have the same problem.

[dlang-bot]

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	24340	blocker	Invalid export directives generated

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16047"

[rikkimax]

I dug into the history of this, appears you introduced it @rainers :P

https://github.com/dlang/dmd/blame/d60fbe8d140339de1826a50351eb8e6656e8bc70/src/ddmd/backend/mscoffobj.c#L1789

[rikkimax]

Hmm, checking my export list, why are unittests being exported? Weird.

[thewilsonator]

Test case?

[rikkimax]

There is a zero chance of regression.

It was a simple mistake of using the stack memory instead of pointer returned (which could be heap allocated).

[RazvanN7]

cc @rainers

[rainers]

Indeed, looks like a typo.