Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.d: Support building with LDC on macOS arm64, by specifying -mtriple to select x86_64 target #16239

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

JohanEngelen
Copy link
Contributor

To build DMD, the command becomes:
HOST_DMD="<path to ldc>/bin/ldmd2" DFLAGS="-mtriple=x86_64-apple-macos11" DMD="<path to ldc>/bin/ldmd2" make

this requires the universal macOS package of LDC. The universal package contains stdlib binaries to enable linking an x86_64 executable.

…iple to select x86_64 target:

`HOST_DMD="<path to ldc>/bin/ldmd2" DFLAGS="-mtriple=x86_64-apple-macos11" DMD="<path to ldc>/bin/ldmd2" make`
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16239"

@JohanEngelen
Copy link
Contributor Author

CI failures on macOS 13 are known issues and unrelated to this PR. (although this PR would help in that it enables solving this known issue by switching to LDC to build on macOS 13).

@thewilsonator thewilsonator merged commit 43131f9 into dlang:master Feb 23, 2024
46 of 48 checks passed
@JohanEngelen JohanEngelen deleted the support_ldc_arm64 branch February 23, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants