Fix issue 9438 - Strange RefCounted stack overflow #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added a commit
that referenced
this pull request
Feb 11, 2013
Fix issue 9438 - Strange RefCounted stack overflow
WalterBright
added a commit
to WalterBright/dmd
that referenced
this pull request
Feb 11, 2013
Fix issue 9438 - Strange RefCounted stack overflow
|
Thanks for tracking this one down. That was a tough job, and this is a critical fix. |
ghost
deleted the
9rnsr
pushed a commit
to 9rnsr/dmd
that referenced
this pull request
Feb 11, 2013
Fix issue 9438 - Strange RefCounted stack overflow
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 9438.
When except_fillInEHTable() calculates offset for DHandlerTable for destructors of temporary objects, it does it twice, so calculated offset is bigger than necessary, so druntime unwinds up to wrong asm instruction, so program goes off the rails. It seems that it worked with -g by chance, since with -g operand queue contains more special elements for which calccodesize() returns zero.