From 6313e1ce2bab03f0a956da7fb58378db4d60729c Mon Sep 17 00:00:00 2001 From: Andrea Fontana Date: Sat, 11 May 2024 15:14:40 +0200 Subject: [PATCH 1/2] Adding a note --- druntime/src/importc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/druntime/src/importc.h b/druntime/src/importc.h index 138917151991..98d223e3f0a2 100644 --- a/druntime/src/importc.h +++ b/druntime/src/importc.h @@ -138,6 +138,7 @@ typedef unsigned long long __uint64_t; // This header disables the Windows API Annotations macros // Need to include sal.h to get the pragma once to prevent macro redefinition. +// Note: these includes cause the compilation to fail if the environment has not been configured using vcvars. #include "sal.h" #include "no_sal2.h" #endif From 002fc0ec7922ffdffb98feaf14972107f1793f8a Mon Sep 17 00:00:00 2001 From: Nicholas Wilson Date: Sun, 12 May 2024 14:26:31 +0800 Subject: [PATCH 2/2] Update importc.h Improve message about VS envvars. --- druntime/src/importc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/druntime/src/importc.h b/druntime/src/importc.h index 98d223e3f0a2..e6ba4de250ea 100644 --- a/druntime/src/importc.h +++ b/druntime/src/importc.h @@ -138,7 +138,9 @@ typedef unsigned long long __uint64_t; // This header disables the Windows API Annotations macros // Need to include sal.h to get the pragma once to prevent macro redefinition. -// Note: these includes cause the compilation to fail if the environment has not been configured using vcvars. +// Note: these includes require include paths to `cl.exe` as envoronment variables that are set by +// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions +// This will cause the compilation to fail (error C1083) if the environment has not been properly configured prior. #include "sal.h" #include "no_sal2.h" #endif