Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

9495: Fixes issue with variadic functions on win64 #1657

Merged
merged 4 commits into from Mar 3, 2013

Conversation

Projects
None yet
4 participants
Contributor

Ingrater commented Feb 12, 2013

Which only appears if the argument before the variadic arguments is > 8 byte
http://d.puremagic.com/issues/show_bug.cgi?id=9495

Owner

WalterBright commented Feb 20, 2013

Please add test case.

Contributor

Govelius commented Feb 27, 2013

@Ingrater could you rebase this pull request into just 2 commits, the change and the testsuite code?
it makes the git history look alot cleaner.

Contributor

Ingrater commented Feb 27, 2013

Are there some instructions around how to do that?

Contributor

Govelius commented Feb 27, 2013

  1. To redo commits, I use interactive mode "git rebase -i <last good commit>"
  2. instead of merging upstream/master, rebase your commits over it
git checkout pull9495
git fetch upstream
git rebase upstream/master

Note: when you push you'll have to --force

Member

MartinNowak commented Feb 27, 2013

test9495 should not be compiled with -release

Why?

Contributor

Ingrater commented Mar 2, 2013

Because the asserts are gone then?

@WalterBright WalterBright added a commit that referenced this pull request Mar 3, 2013

@WalterBright WalterBright Merge pull request #1657 from Ingrater/pull9495
9495: Fixes issue with variadic functions on win64
76b8f79

@WalterBright WalterBright merged commit 76b8f79 into dlang:master Mar 3, 2013

1 check was pending

default Pass: 8, Pending: 2
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment