Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla 12885 - const union wrongly converts implicitly to mutable #16594

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jun 17, 2024

This disables code that breaks immutable which was added for https://issues.dlang.org/show_bug.cgi?id=11257#c3, for -preview=fixImmutableConv only.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
12885 major const union wrongly converts implicitly to mutable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16594"

@thewilsonator
Copy link
Contributor

should this go to stable?

Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine in master since it's very old.

@dlang-bot dlang-bot merged commit 15f66f8 into dlang:master Jun 20, 2024
41 checks passed
@ntrel ntrel deleted the union-conv branch June 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants