Fix bugzilla 24337 - Segfault when printing an int[] cast from a stri… #16729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#16729" |
dkorpel
force-pushed
the
pragma-msg-segfault
branch
2 times, most recently
from
6e254f1
to
77102b9
Compare
dkorpel
force-pushed
the
pragma-msg-segfault
branch
from
77102b9
to
bb41c7e
Compare
thewilsonator
approved these changes
Jul 21, 2024
| * Returns: | ||
| * true on error | ||
| */ | ||
| bool expressionsToString(ref OutBuffer buf, Scope* sc, Expressions* exps) | ||
| bool expressionsToString(ref OutBuffer buf, Scope* sc, Expressions* exps, | ||
| Loc loc, const(char)* fmt, bool expandTuples) |
There was a problem hiding this comment.
fmt, expandTuples could default to null, true.
There was a problem hiding this comment.
https://github.com/dlang/dmd/blob/master/CONTRIBUTING.md says:
- Avoid the use of default parameters. Spell them out.
RazvanN7
approved these changes
Jul 22, 2024
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
Oct 7, 2024
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
Oct 7, 2024
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
Oct 7, 2024
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
Oct 7, 2024
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
Oct 7, 2024
RazvanN7
added a commit
that referenced
this pull request
Oct 7, 2024
* Document template instance duplication status as part of its field documentation. (#16643) * Fix Bugzilla 24599 - Wrongly elided TypeInfo emission (#15868) Reverting #14844, which caused such missing TypeInfos, *and* making sure the special TypeInfo members are fully analyzed and ready for codegen (otherwise hitting an assertion for the real-world project). * Reorganize backend build files to match target and make more similar per line (#16672) * Remove redundant suggestions on linker errors (#16711) * Fix bugzilla 24337 - Segfault when printing an int[] cast from a string (#16729) * Add BitFieldStyle.Gcc_Clang_ARM Required for 32-bit ARM, and non-Apple 64-bit ARM targets. The only difference to `Gcc_Clang` is that anonymous and 0-length bit-fields do contribute to the aggregate alignment. Caught by existing proper C interop tests in runnable_cxx/testbitfields.d on such targets. The hardcoded bad tests in runnable/{bitfieldsposix64.c,dbitfieldsposix64.d} however now fail after the fix, on such targets again. * [refactor to `TargetC.contributesToAggregateAlignment(BitFieldDeclaration)` hook] * Fix Bugzilla Issue 24687 - [REG2.110] Cannot cast string-imports to select overload anymore * Also make deprecationSupplemental adhere to error limit (#16779) Co-authored-by: Dennis Korpel <dennis@sarc.nl> * Fix bugzilla 24699 - [REG2.108] No short-circuit evaluation of mixing template bool argument * Fix bugzilla 24731 - IFTI cannot handle integer expressions (#16822) * Fix Bugzilla Issue 24760 - ICE on variadic after default argument * Fix bugzilla 24790 - -vcg-ast ICE on lowered assign exp (#16914) Co-authored-by: Dennis Korpel <dennis@sarc.nl> * Fix bugzilla 24764 - ICE when -vcg-ast prints imported invariant (#16917) Co-authored-by: Dennis Korpel <dennis@sarc.nl> * Fix bugzilla 24431 - dmd -vcg-ast crashes printing failed template in… (#16916) --------- Co-authored-by: Richard (Rikki) Andrew Cattermole <richard@cattermole.co.nz> Co-authored-by: Martin Kinkelin <kinke@users.noreply.github.com> Co-authored-by: Dennis <dkorpel@users.noreply.github.com> Co-authored-by: Martin Kinkelin <mkinkelin@symmetryinvestments.com> Co-authored-by: Martin Kinkelin <noone@nowhere.com> Co-authored-by: RazvanN7 <razvan.nitu1305@gmail.com> Co-authored-by: Dennis Korpel <dennis@sarc.nl> Co-authored-by: Dennis Korpel <dkorpel@gmail.com>
royalpinto007
pushed a commit
to royalpinto007/dmd
that referenced
this pull request
Oct 11, 2024
royalpinto007
pushed a commit
to royalpinto007/dmd
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng literal
Let
pragma(msg)useexpressionsToStringjust likemixin(), and only calltoUTF8on string expressions that an element type thatisSomeChar.