Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla Issue 24687 - [REG2.110] Cannot cast string-imports to select overload anymore #16770

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Aug 5, 2024

When checking if an expression is implicitly convertible to a type the current implementation of hexstring assumes that the match is convert irrespective of what the actual types are. Fix this by considering the case where the types are identical.

cc @dkorpel as the original author.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24687 regression [REG2.110] Cannot cast string-imports to select overload anymore

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16770"

@@ -704,7 +704,7 @@ MATCH implicitConvTo(Expression e, Type t)
return MATCH.nomatch;
m = MATCH.constant;
}
if (e.hexString && tn.isintegral && (tn.size == e.sz || (!e.committed && (e.len % tn.size) == 0)))
if (e.type != t && e.hexString && tn.isintegral && (tn.size == e.sz || (!e.committed && (e.len % tn.size) == 0)))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be expressed as a separate condition at the beginning of this function:

if (e.type == t)
    return MATCH.exact;

However, I wanted it to be localized to the actual code that introduced the regression. Arguably, this condition should be first executed by the implicitConvTo function, however, I believe that when it was implemented the expectation was that this would be checked at the call site before actually calling implicitConvTo.

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was a bit puzzled by the issue, and was afraid it would require another match level to fix, but you found a straightforward fix

@dlang-bot dlang-bot merged commit 29a3418 into dlang:stable Aug 6, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants