Fix bugzilla 24699 - [REG2.108] No short-circuit evaluation of mixing… #16781
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#16781" |
| @@ -4556,9 +4556,15 @@ extern (C++) class TemplateInstance : ScopeDsymbol | |||
|
|
|||
| // The arguments are not treated as part of a default argument, | |||
| // because they are evaluated at compile time. | |||
| const inCondition = !!(sc.flags && SCOPE.condition); | |||
| // For master branch: const inCondition = sc.condition; | |||
There was a problem hiding this comment.
Kind of annoying that this refactoring isn't in stable yet, does a comment like this help when merging stable @ibuclaw ?
… template bool argument
dkorpel
force-pushed
the
template-condition-regression
branch
from
433c562
to
dd409f4
Compare
| sc = sc.push(); | ||
| sc.inDefaultArg = false; | ||
|
|
||
| // https://issues.dlang.org/show_bug.cgi?id=24699 | ||
| sc.flags |= SCOPE.condition * inCondition; |
There was a problem hiding this comment.
please write this as if (inCondition) sc.flags |= SCOPE.condition;.
multiplication of bool and flags is just plain confusing.
There was a problem hiding this comment.
Doesn't really matter, it's just temporary code standing in until the next stable merge
… template bool argument