Kill deprecated implicit conversion from T[] to T* #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@WalterBright, this is a language change, but you should check this in high priority. |
|
I guess this is related to #1292, right? |
|
@leandro-lucarella-sociomantic No, there is no relation. |
| @@ -4296,9 +4297,9 @@ MATCH TypeDArray::implicitConvTo(Type *to) | |||
| return MATCHconvert; | |||
| } | |||
|
|
|||
| return next->constConv(to) ? MATCHconvert : MATCHnomatch; | |||
| return next->constConv(tp->next) ? MATCHconvert : MATCHnomatch; | |||
There was a problem hiding this comment.
Why has that piece of code worked before?
There was a problem hiding this comment.
It didn't - see Kenji's explanation in bug 9539.
|
How do I merge this if github won't? |
|
I've rebased commits on the head of master. |
WalterBright
added a commit
that referenced
this pull request
Feb 22, 2013
Kill deprecated implicit conversion from T[] to T*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to fix a regression.
Issue 9539 - Regression (2.061): Wrong-code on static array pointer
See my detailed explanation in here
Just I should say here is: the deprecated implicit conversion feature already being a cancer in D2 type system.