Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla Issue 24760 - ICE on variadic after default argument #16834

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

RazvanN7
Copy link
Contributor

This used to be illegal prior to the addition of named arguments, however, now it has become legal. One way to fix this would have been to disallow this pattern, but since the fix is quite simple I just went ahead and accepted it as valid code.

Not targeting stable as I'm having doubts that this is a pattern we should support.

@dlang-bot
Copy link
Contributor

dlang-bot commented Sep 11, 2024

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24760 normal ICE on variadic after default argument

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16834"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICE should go to stable. Otherwise looks good

@RazvanN7
Copy link
Contributor Author

@thewilsonator ok. done.

@dlang-bot dlang-bot merged commit 219b4f0 into dlang:stable Sep 12, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants