-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugzilla issue 24153 - Inliner breaks -betterC by requiring TypeInfo #17049
Fix bugzilla issue 24153 - Inliner breaks -betterC by requiring TypeInfo #17049
Conversation
|
Thanks for your pull request and interest in making D better, @bangbangsheshotmedown! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This otherwise looks good. If you consider this issue to be a blocker, you might want to rebase to target stable instead of master.
I don't know how to do that, the command fails: |
|
For a small PR like this it's probably easier to just recreate it locally on stable and then and open a new PR. Saves messing around with git. Just make sure to select stable when choosing with branch to target. |
Do you think it is worth it? I checked stable and that code lives in a different file, I feel like it'll cause some issues when merging later? |
|
If you are fine waiting a while for it to get into a release then you don't need to. Do you want me to merge this as is now? |
I use LDC for release build, so it doesn't really impact me, I guess you can merge it as is |
No description provided.