Fix bugzilla issue 24835. #17056
Merged
Fix bugzilla issue 24835. #17056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @jmdavis! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17056" |
I don't know why hasElaborateAssign even bothers to look at the member variable, since the compiler should be generating opAssign for the struct if any of its member variables has one, but doing that check then incorrectly reports that the struct has opAssign when that opAssign is @disabled. So, this fixes it so that it just checks the struct itself for opAssign. Ultimately, that's what matters anyway.
|
@WalterBright This is a blocker bug for Ranges in Phobos V3, can we get a priority review on this? |
thewilsonator
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why hasElaborateAssign even bothers to look at the member variable, since the compiler should be generating opAssign for the struct if any of its member variables has one, but doing that check then incorrectly reports that the struct has opAssign when that opAssign is @disabled.
So, this fixes it so that it just checks the struct itself for opAssign. Ultimately, that's what matters anyway.