Add assertion and fix AST identity that had broken by template instantiation #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes the issues I'm seeing. @WalterBright: Could you please have a look at the change? I don't want to merge it myself as I'm not sure what implicit assumptions about the interaction of deferred semantic runs and mixin templates might have been made elsewhere in the code. |
|
@donc I think you also know well about this area. Could you please review this? |
donc
pushed a commit
that referenced
this pull request
Mar 19, 2013
Add assertion and fix AST identity that had broken by template instantiation
|
This pull request may have introduced a regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned by @klickverbot in dmd-internal forum.
http://forum.dlang.org/thread/CAP9J_HXbtgevkav0DvowRHsTfT=S1zWh=wnzyqkGVoGqs34Nzw@mail.gmail.com