Optimize simple array comparisons (Issue 9477) #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, Phobos is failing. Not done yet... |
|
It would be nice to have some more comments in there, explaining exactly what you're building. |
|
Looks like my test has uncovered yet another new bug (unrelated to my patch)... That would be the fifth one! |
|
Updated with Win64 test workaround and more comments. |
Triggered on Linux by test81 in interpret.d with the array comparison optimization patch.
|
The DMD git mishap caused GitHub to screw up (it was showing others' commits that were in master anyway). Rebased on HEAD, that seems to have fixed it. |
WalterBright
added a commit
that referenced
this pull request
Mar 31, 2013
Optimize simple array comparisons (Issue 9477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was fun!