Issue 2156 - [] and null should be accepted where a compile-time string is required #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng is required Instead of checking for TOKstring, use toString to check if a string, array literal or null literal can be used.
|
|
||
| if (telem == Tchar || telem == Twchar || telem == Tdchar) | ||
| { | ||
| Expression *e = castTo(sc, Type::tstring)->interpret(NULL); |
There was a problem hiding this comment.
This should be done as optimize(WANTvalue | WANTinterpret), rather than a direct call to interpret(). But, it's already been interpreted,* so the whole thing is unnecessary. If any element of the array is anything other than TOKint64, it's not convertible to string.
- except the GNU_asm pragma. This should be changed.
|
Superseded by pull #362. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 2156 - [] and null should be accepted where a compile-time string is required
Instead of checking for TOKstring, use toString to check if a string, array literal or null literal can be used.
http://d.puremagic.com/issues/show_bug.cgi?id=2156