Issue 4539 - Refuse assignment to string literal #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reapply pull 46 This reverts commit c0e4967.
|
It's clear that string literals should never be usable as modifiable lvalues, so test42 is clearly wrong. |
|
That I can do. Thanks for reviewing these btw. |
|
See also: pull request #164. |
|
Closing as a duplicate of #164. |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Sep 15, 2011
GDC Win64 patch for Phobos2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #46
and fixes http://d.puremagic.com/issues/show_bug.cgi?id=4539
Disable using string literals as lvalues and change the dmd tests that rely on this behavior.