Issue 1891 - Array-concatenation of T* and T*[] produces corrupted result #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult CatExp::toElem was a mess, using Type::nextOf to determine if a type was an array. Naturally this failed when the first type derived from TypeNext but was not an array. This also cleans out a bunch of dead code from CatExp::toElem, that seems to have been there since 2.011.
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Sep 15, 2011
Remove .get from std.datetime
WalterBright
added a commit
that referenced
this pull request
Oct 4, 2011
Issue 1891 - Array-concatenation of T* and T*[] produces corrupted result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1891 - Array-concatenation of T* and T*[] produces corrupted result
CatExp::toElem was a mess, using Type::nextOf to determine if a type was an array. Naturally this failed when the first type derived from TypeNext but was not an array.
This also cleans out a bunch of dead code from CatExp::toElem, that seems to have been there since 2.011.
http://d.puremagic.com/issues/show_bug.cgi?id=1891