-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 10302 - Package module conflicts with package name #2152
Conversation
| @@ -32,9 +32,19 @@ | |||
| struct elem; | |||
| #endif | |||
|
|
|||
| enum PKG | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comments on what these values mean.
|
Kenji, your comments above are much better than the ones you put in the source code! Please make it the other way around. |
|
Awesome, let's merge this soon. |
|
I updated comments in code.
Just same description is already in the commit log. |
| enum PKG | ||
| { | ||
| PKGunknown, // not yet determined whether it's a package module or not | ||
| PKGmodule, // already determined that's an actual package module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. package.d, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I rewrote "package module" to "package.d".
|
This needs to go into the code as comments: Also, some explanation that a "package module" is "package.d". Having these comments in the commit log isn't good enough, because when people try to understand the code they look at comments in the code, not in the commit log. |
|
Thanks for your reviewing. I updated the explanation comment and inserted it in the source code. |
|
Awesome! Thanks, Kenji. |
Issue 10302 - Package module conflicts with package name
http://d.puremagic.com/issues/show_bug.cgi?id=10302
...and small fix up for #2139.
If the source tree is as follows:
A package module will be incorporated to the internal package tree in two ways:
import pkg;andimport pkg.common;.Current code considers either only one of them will occur. If both case occurs at the same time, like as
import pkg; import pkg.common;, pkg as aModuleand pkg as aPackagewill conflict each other.To solve the problem, I added two fields
isPkgModandmodinPackageclass.