Issue 10302 - Package module conflicts with package name

[9rnsr]

http://d.puremagic.com/issues/show_bug.cgi?id=10302

...and small fix up for #2139.

If the source tree is as follows:

pkg/
+ package.d
+ common.d

A package module will be incorporated to the internal package tree in two ways: import pkg; and import pkg.common;.

Current code considers either only one of them will occur. If both case occurs at the same time, like as import pkg; import pkg.common;, pkg as a Module and pkg as a Package will conflict each other.

To solve the problem, I added two fields isPkgMod and mod in Package class.

[WalterBright]

Please add comments on what these values mean.

[WalterBright]

Kenji, your comments above are much better than the ones you put in the source code! Please make it the other way around.

[andralex]

Awesome, let's merge this soon.

[9rnsr]

I updated comments in code.

Kenji, your comments above are much better than the ones you put in the source code! Please make it the other way around.

Just same description is already in the commit log.

[WalterBright]

i.e. package.d, right?

[9rnsr]

Right. I rewrote "package module" to "package.d".

[WalterBright]

This needs to go into the code as comments:

If the source tree is as follows:
  pkg/
  + package.d
  + common.d
A package can be incorporated into the internal package tree in two ways:
  import pkg; // pulls in pkg/package.d
  import pkg.common; // does not look at pkg/package.d
If both imports occur, pkg as a Module and pkg as a Package will conflict each other.
To fix this, we do [...]

Also, some explanation that a "package module" is "package.d".

Having these comments in the commit log isn't good enough, because when people try to understand the code they look at comments in the code, not in the commit log.

[9rnsr]

Thanks for your reviewing. I updated the explanation comment and inserted it in the source code.

[WalterBright]

Awesome! Thanks, Kenji.