Bug 6284: [Regression 2.054] 'pure' does not work with 'with' statement #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually this solves a more generic regression, where
Structure* s = ...;
auto b = s.a;
cannot be used in 'pure' function. Not sure if this is allowed or not, but I think it is correct, because
1. There is no way to get a reference to some global variable from internal without refering it first, which the 'pure' check can handle,
2. Accessing and modifying members are already possible via methods,
3. Even if this is restricted to `__withSym`, this can be worked-around using `with(*s) { ... }` anyway.
|
Closing as I have a more complete and organized solution that also solves bug 6293. |
braddr
pushed a commit
to braddr/dmd
that referenced
this pull request
Sep 15, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 6284.
Actually this solves a more generic regression, where
cannot be used in 'pure' function. Not sure if this is allowed or not, but I think it is correct, because
purecheck can handle,__withSym, this can be worked-around usingwith(*s) { ... }anyway.